Adding documentation for watch and proxied objects #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@bencodezen told me to tag him in this as well. |
Merged
Member
NataliaTepluhina
left a comment
NataliaTepluhina
left a comment
There was a problem hiding this comment.
@fimion thank you for working on this! I've added a few comments to the PR
fimion
force-pushed
the
docs-next/733
branch
from
7c37314 to
9dc8dd1
Compare
Co-authored-by: Natalia Tepluhina <[email protected]>
fimion
force-pushed
the
docs-next/733
branch
from
9dc8dd1 to
6abcf91
Compare
Member
NataliaTepluhina
left a comment
NataliaTepluhina
left a comment
There was a problem hiding this comment.
@fimion thank you for all the changes! I've added a few more points to review
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
bencodezen
approved these changes
Jan 8, 2021
Member
bencodezen
left a comment
bencodezen
left a comment
There was a problem hiding this comment.
Thanks for your work on this @fimion and @NataliaTepluhina for the great reviews!
I think we're good to go for release so people can utilize this information. We can always iterate in another PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
The way a developer needs to use watch on a proxied object is not well documented. I have outlined more details in #733
Proposed Solution
Add details about shallow copying and deep copying an object to see both the old and new values of it.
Additional Information